Repository navigation
fix: fixed hanging in NA if url has hash - #7698
Merged
Merged
Conversation
miherlosev
requested changes
May 12, 2023
| } | ||
|
|
||
| function setLocation (command, opts) { | ||
| const hashIndex = command.url.indexOf('#'); |
Collaborator
There was a problem hiding this comment.
const hasHash = ...
const onlyHashChanged =...
Collaborator
Author
There was a problem hiding this comment.
I disagree with hasHash, because we need to get a hash index to check that only hash has changed.
AlexKamaev
removed their request for review
May 12, 2023 07:57
miherlosev
approved these changes
May 12, 2023
miherlosev
enabled auto-merge (squash)
May 16, 2023 03:01
miherlosev
disabled auto-merge
May 16, 2023 03:02
|
Release v2.6.1-rc.1 addresses this. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[closes #7652]
Purpose
Fix hanging
Approach
Force page reloading page between tests in NA if URL has a hash.
References
#7652
Pre-Merge TODO